From: "Stefan Sterz" <s.sterz@proxmox.com>
To: "Stefan Sterz" <s.sterz@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`
Date: Wed, 10 Apr 2024 09:51:39 +0200 [thread overview]
Message-ID: <D0GA2A6X6G12.18MHQZGI7SR1S@proxmox.com> (raw)
In-Reply-To: <20231016162848.2546638-1-s.sterz@proxmox.com>
On Mon Oct 16, 2023 at 6:28 PM CEST, Stefan Sterz wrote:
> some icons intentionally use black as their color in the light theme.
> this includes the little pencil and check mark icon in the acme
> overview. change their color to the regular dark-mode icon-color. for
> this to work the filter inversion needed for some other icons needs to
> be remove too.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> src/proxmox-dark/scss/other/_icons.scss | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
> index d4dc316..c045cf4 100644
> --- a/src/proxmox-dark/scss/other/_icons.scss
> +++ b/src/proxmox-dark/scss/other/_icons.scss
> @@ -104,6 +104,9 @@
> }
>
> // pbs show task log in longest task list column
> +.fa.black,
> +.fa.black::after,
> +.fa.black::before,
> .x-action-col-icon.fa-chevron-right::before {
> filter: none;
> }
> @@ -222,6 +225,12 @@
> }
> }
>
> +// set icon color of intentional black icons (e.g.: pencil icon for
> +// quickly changing the ACME account)
> +.fa.black {
> + color: $icon-color;
> +}
> +
> // The usage icons dynamically displaying how full a storage is
> .usage-wrapper {
> border: 1px solid $icon-color;
> --
> 2.39.2
ping, this still applies for me :)
next prev parent reply other threads:[~2024-04-10 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:28 Stefan Sterz
2024-04-10 7:51 ` Stefan Sterz [this message]
2024-04-10 8:29 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0GA2A6X6G12.18MHQZGI7SR1S@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox