public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager/widget-toolkit 0/3] ui: avoid UI bugs due to shared extra request params
@ 2024-04-03  9:10 Friedrich Weber
  2024-04-03  9:10 ` [pve-devel] [PATCH manager 1/3] ui: pool members: avoid setting request parameter for all edit windows Friedrich Weber
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Friedrich Weber @ 2024-04-03  9:10 UTC (permalink / raw)
  To: pve-devel

Currently, `Proxmox.window.Edit` initializes `extraRequestParams` to
an object that, if not overwritten, is shared between all instances of
subclasses. This bears the danger of modifying the shared object in a
subclass instead of overwriting it, which affects all edit windows of
the current session and can cause hard-to-catch UI bugs [1]

- Patch 1/3 fixes such an UI bug.
- Patch 2/3 (optional) fixes other occurrences of the pattern from 1/3,
  which are not buggy at the moment, but may become in the future.
- Patch 3/3 (optional) changes `Proxmox.window.Edit` to make this
  class of bugs less likely in the future.

Changes from v1:

- Patch 1/3: avoid unnecessary quotes
- Patch 2/3 + 3/3 are new

[1] https://lists.proxmox.com/pipermail/pve-devel/2024-March/062179.html

manager:

Friedrich Weber (2):
  ui: pool members: avoid setting request parameter for all edit windows
  ui: pool members: avoid sharing object for extra request parameters

 www/manager6/grid/PoolMembers.js | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)


widget-toolkit:

Friedrich Weber (1):
  window: edit: avoid shared object for extra request params

 src/window/Edit.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)


Summary over all repositories:
  2 files changed, 10 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.5.0




^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-04-04 11:28 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-03  9:10 [pve-devel] [PATCH manager/widget-toolkit 0/3] ui: avoid UI bugs due to shared extra request params Friedrich Weber
2024-04-03  9:10 ` [pve-devel] [PATCH manager 1/3] ui: pool members: avoid setting request parameter for all edit windows Friedrich Weber
2024-04-03  9:10 ` [pve-devel] [PATCH manager 2/3] ui: pool members: avoid sharing object for extra request parameters Friedrich Weber
2024-04-03  9:10 ` [pve-devel] [PATCH widget-toolkit 3/3] window: edit: avoid shared object for extra request params Friedrich Weber
2024-04-04  8:22   ` Stefan Sterz
2024-04-04  9:01     ` Friedrich Weber
2024-04-04  9:23       ` Stefan Sterz
2024-04-04 10:10         ` Friedrich Weber
2024-04-04 10:54           ` Stefan Sterz
2024-04-04 11:04             ` Stefan Sterz
2024-04-04 10:59           ` Thomas Lamprecht
2024-04-04 11:28             ` Friedrich Weber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal