From: "Max Carrara" <m.carrara@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 pve-network 4/5] tests: disable failing DNS tests
Date: Mon, 25 Mar 2024 14:21:12 +0100 [thread overview]
Message-ID: <D02V1VXXWAVM.32Q5ATGWYKOR7@proxmox.com> (raw)
In-Reply-To: <20240307151319.301984-6-s.lendl@proxmox.com>
On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote:
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> src/test/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/test/Makefile b/src/test/Makefile
> index eb59d5f..db70c89 100644
> --- a/src/test/Makefile
> +++ b/src/test/Makefile
> @@ -1,6 +1,6 @@
> all: test
>
> -test: test_zones test_ipams test_dns test_subnets
> +test: test_zones test_ipams test_subnets
Interestingly enough, these don't fail for me at all... do you know what
tests failed for you in the first place, perhaps? All of them?
Otherwise, I'd suggest just dropping this patch if the tests run fine
now - no need to disable them after all then.
>
> test_zones: run_test_zones.pl
> ./run_test_zones.pl
next prev parent reply other threads:[~2024-03-25 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:13 [pve-devel] [PATCH v2 pve-network 0/5] SDN tests in sbuild Stefan Lendl
2024-03-07 15:13 ` [pve-devel] [PATCH v2 pve-network 1/5] refactor(controllers): extract read_etc_network_interfaces Stefan Lendl
2024-03-25 13:19 ` Max Carrara
2024-03-07 15:13 ` [pve-devel] [PATCH v2 pve-network 2/5] refactor(evpn): extract read_local_frr_config Stefan Lendl
2024-03-25 13:20 ` Max Carrara
2024-03-07 15:13 ` [pve-devel] [PATCH v2 pve-network 3/5] tests: mocking more functions to avoid system access Stefan Lendl
2024-03-25 13:21 ` Max Carrara
2024-03-07 15:13 ` [pve-devel] [PATCH v2 pve-network 4/5] tests: disable failing DNS tests Stefan Lendl
2024-03-25 13:21 ` Max Carrara [this message]
2024-03-07 15:13 ` [pve-devel] [PATCH v2 pve-network 5/5] tests: run tests in sbuild Stefan Lendl
2024-03-25 13:24 ` [pve-devel] [PATCH v2 pve-network 0/5] SDN " Max Carrara
2024-04-02 11:10 ` Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D02V1VXXWAVM.32Q5ATGWYKOR7@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox