* [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit
@ 2024-02-23 11:45 Hannes Laimer
2024-02-23 11:51 ` Aaron Lauterer
0 siblings, 1 reply; 3+ messages in thread
From: Hannes Laimer @ 2024-02-23 11:45 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
came up in enterprise support, and I don't think there is a reason to
not have it in the UI, while having it in the API
www/manager6/storage/DirEdit.js | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 3e2025fc..52e7134b 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
},
];
+ me.advancedColumn2 = [
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'is_mountpoint',
+ uncheckedValue: 0,
+ fieldLabel: gettext('Mountpoint'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),
+ },
+ },
+ ];
me.callParent();
},
});
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit
2024-02-23 11:45 [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit Hannes Laimer
@ 2024-02-23 11:51 ` Aaron Lauterer
2024-02-23 11:59 ` Hannes Laimer
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Lauterer @ 2024-02-23 11:51 UTC (permalink / raw)
To: Proxmox VE development discussion, Hannes Laimer
Overall good idea :)
On 2/23/24 12:45, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
>
> www/manager6/storage/DirEdit.js | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> index 3e2025fc..52e7134b 100644
> --- a/www/manager6/storage/DirEdit.js
> +++ b/www/manager6/storage/DirEdit.js
> @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
> },
> ];
>
> + me.advancedColumn2 = [
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'is_mountpoint',
> + uncheckedValue: 0,
> + fieldLabel: gettext('Mountpoint'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),
Maybe phrase the tooltip like this?
Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.
As there are also use-cases where something local is mounted outside of the PVE tooling where the is_mountpoint option is useful.
> + },
> + },
> + ];
> me.callParent();
> },
> });
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit
2024-02-23 11:51 ` Aaron Lauterer
@ 2024-02-23 11:59 ` Hannes Laimer
0 siblings, 0 replies; 3+ messages in thread
From: Hannes Laimer @ 2024-02-23 11:59 UTC (permalink / raw)
To: Aaron Lauterer, Proxmox VE development discussion
On Fri Feb 23, 2024 at 12:51 PM CET, Aaron Lauterer wrote:
> Overall good idea :)
>
> On 2/23/24 12:45, Hannes Laimer wrote:
> > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> > ---
> >
> > came up in enterprise support, and I don't think there is a reason to
> > not have it in the UI, while having it in the API
> >
> > www/manager6/storage/DirEdit.js | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> > index 3e2025fc..52e7134b 100644
> > --- a/www/manager6/storage/DirEdit.js
> > +++ b/www/manager6/storage/DirEdit.js
> > @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
> > },
> > ];
> >
> > + me.advancedColumn2 = [
> > + {
> > + xtype: 'proxmoxcheckbox',
> > + name: 'is_mountpoint',
> > + uncheckedValue: 0,
> > + fieldLabel: gettext('Mountpoint'),
> > + autoEl: {
> > + tag: 'div',
> > + 'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),
>
> Maybe phrase the tooltip like this?
>
> Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.
sure, I'll send a v2
>
>
> As there are also use-cases where something local is mounted outside of the PVE tooling where the is_mountpoint option is useful.
>
> > + },
> > + },
> > + ];
> > me.callParent();
> > },
> > });
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-23 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 11:45 [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit Hannes Laimer
2024-02-23 11:51 ` Aaron Lauterer
2024-02-23 11:59 ` Hannes Laimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox