* [pve-devel] [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button
@ 2023-07-27 12:47 Lukas Wagner
2023-08-02 8:02 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 3+ messages in thread
From: Lukas Wagner @ 2023-07-27 12:47 UTC (permalink / raw)
To: pve-devel
Before, there was zero space between the the grid border line and the
button, making it look a bit odd.
The ListField form component is currently used in the
'User Tag Access' and 'Registered Tags' dialog windows in datacenter
option view.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/form/ListField.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/form/ListField.js b/www/manager6/form/ListField.js
index 61e37f7e..0d0a4f6e 100644
--- a/www/manager6/form/ListField.js
+++ b/www/manager6/form/ListField.js
@@ -144,6 +144,7 @@ Ext.define('PVE.form.ListField', {
text: gettext('Add'),
iconCls: 'fa fa-plus-circle',
handler: 'addLine',
+ margin: '5 0 0 0',
},
],
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button
2023-07-27 12:47 [pve-devel] [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button Lukas Wagner
@ 2023-08-02 8:02 ` Thomas Lamprecht
2023-08-02 8:14 ` Lukas Wagner
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Lamprecht @ 2023-08-02 8:02 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 27/07/2023 um 14:47 schrieb Lukas Wagner:
> Before, there was zero space between the the grid border line and the
> button, making it look a bit odd.
>
> The ListField form component is currently used in the
> 'User Tag Access' and 'Registered Tags' dialog windows in datacenter
> option view.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/form/ListField.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
FWIW, it might be also look slightly better, and save some space, if we'd
move the add button inside the grid, i.e., at the right side below the last
row. Would also shorten the way one has to move between adding a new tag input
and editing that tag.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button
2023-08-02 8:02 ` [pve-devel] applied: " Thomas Lamprecht
@ 2023-08-02 8:14 ` Lukas Wagner
0 siblings, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2023-08-02 8:14 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox VE development discussion
On Wed Aug 2, 2023 at 10:02 AM CEST, Thomas Lamprecht wrote:
> FWIW, it might be also look slightly better, and save some space, if we'd
> move the add button inside the grid, i.e., at the right side below the last
> row. Would also shorten the way one has to move between adding a new tag input
> and editing that tag.
True, that might be a good idea. I'll give that a try when I get around to it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-02 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-27 12:47 [pve-devel] [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button Lukas Wagner
2023-08-02 8:02 ` [pve-devel] applied: " Thomas Lamprecht
2023-08-02 8:14 ` Lukas Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox