From: Aaron Carson <aaron@aaroncarson.co.uk>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls
Date: Wed, 12 Aug 2026 13:09:14 +0100 [thread overview]
Message-ID: <CANXCxoy1LN8w_o2g55yooV9pFMi4-7jhoyg1n46BV7MgKKwD=g@mail.gmail.com> (raw)
In-Reply-To: <20260806150448.3564005-2-aaron@aaroncarson.co.uk>
https://lore.proxmox.com/pve-devel/20260812120711.3626458-1-aaron@aaroncarson.co.uk/T/#u
On Thu, 6 Aug 2026 at 16:05, Aaron Carson <aaron@aaroncarson.co.uk> wrote:
> Signed-off-by: Aaron Carson <aaron@aaroncarson.co.uk>
> ---
> Hi folks, just a small fix - noticed that the user agent being seen by
> my DNS server was literally USER_AGENT when updating DNS for ACME. I
> know the contribution guide says to discuss before sending in a patch -
> but for a two character fix, thought that was unnecessary. Apologies if
> not though. Thanks!
>
> src/proxmox-acme | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/proxmox-acme b/src/proxmox-acme
> index 705f7df..39c770b 100644
> --- a/src/proxmox-acme
> +++ b/src/proxmox-acme
> @@ -348,9 +348,9 @@ _get_impl() {
> _CURL="$_CURL --connect-timeout $t"
> fi
> if [ "$onlyheader" ]; then
> - $_CURL -I --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> + $_CURL -I --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> else
> - $_CURL --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> + $_CURL --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> fi
> ret=$?
> if [ "$ret" != "0" ]; then
> --
> 2.52.0
>
>
prev parent reply other threads:[~2026-08-12 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 15:04 [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls Aaron Carson
2026-08-12 12:09 ` Aaron Carson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANXCxoy1LN8w_o2g55yooV9pFMi4-7jhoyg1n46BV7MgKKwD=g@mail.gmail.com' \
--to=aaron@aaroncarson.co.uk \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox