Re: [pve-devel] [PATCH pve-kernel] add patch: vhost: bump max_mem_regions to 509

[Alexandre Derumier <aderumier@odiso.com>]

>>What is wrong with setting it as module option?

Nothing wrong.  in 2016, Dietmar wanted it in kernel. (don't remember,
maybe the module option didn't exist at this time)


>>above hunk for the submodule shouldn't be included in the patch, it refers to
>>a git object which is not in ubuntus tree, probably only local in your working
>>tree.
oops, sorry.

Do you prefer a module option file ?

Le lun. 16 nov. 2020 à 11:25, Thomas Lamprecht
<t.lamprecht@proxmox.com> a écrit :
>
> On 15.11.20 19:36, Alexandre Derumier wrote:
> > Currently, default value is 64, so qemu is limited to 64 hotplug dimm
> >
> > original patch from 2015
> > https://patchwork.kernel.org/project/kvm/patch/1438180163-275465-3-git-send-email-imammedo@redhat.com/
> >
> > We have discusted about this in 2016 (At this time some optimisations patches were missing)
> > https://lists.proxmox.com/pipermail/pve-devel/2016-December/024502.html
> >
>
> What is wrong with setting it as module option?
> https://lists.proxmox.com/pipermail/pve-devel/2016-December/024508.html
>
> > Also, this fix this bugzilla
> > https://bugzilla.proxmox.com/show_bug.cgi?id=1426
> >
> > Wolfgang proposed to have explicit dimm module management, it could be great,
> > but for now this patch is fixed the current implemlentation.
> >
> >
>
> maybe Stefan gets around to make this all a nicer approach?
>
> https://lists.proxmox.com/pipermail/pve-devel/2016-December/024519.html
>
> >
> > Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> > ---
> >  ...08-vhost-bump-max_mem_regions-to-509.patch | 32 +++++++++++++++++++
> >  submodules/ubuntu-focal                       |  2 +-
> >  2 files changed, 33 insertions(+), 1 deletion(-)
> >  create mode 100644 patches/kernel/0008-vhost-bump-max_mem_regions-to-509.patch
> snip
> > diff --git a/submodules/ubuntu-focal b/submodules/ubuntu-focal
> > index fd386a6..721ac24 160000
> > --- a/submodules/ubuntu-focal
> > +++ b/submodules/ubuntu-focal
> > @@ -1 +1 @@
> > -Subproject commit fd386a64a1ed3f2f047318508ebd733f56a4fab2
> > +Subproject commit 721ac248403a4c7ea98c416fc28f22c0bfbbb63d
> >
>
> above hunk for the submodule shouldn't be included in the patch, it refers to
> a git object which is not in ubuntus tree, probably only local in your working
> tree.
>
>