From: Thomas Skinner <thomas@atskinner.net>
To: Mira Limbeck <m.limbeck@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH SERIES access-control/docs/manager/proxmox-openid v4] fix #4411: add support for openid groups
Date: Wed, 26 Mar 2025 20:51:10 -0500 [thread overview]
Message-ID: <CALn9RMeuzL2Px7H+Fjg1Qq=0T8Amk6F8h1o4zNdibFTOXyuS-A@mail.gmail.com> (raw)
In-Reply-To: <1345234902.2549.1742920555171@webmail.proxmox.com>
On Tue, Mar 25, 2025 at 11:36 AM Mira Limbeck <m.limbeck@proxmox.com> wrote:
>
> > Thomas Skinner <thomas@atskinner.net> hat am 24.03.2025 03:37 CET geschrieben:
> >
> >
> > Changes since v3:
> > - removed all code/settings/docs for group name replacement characters
> > - conditionally print user added to groups message
> >
> > access-control:
> >
> > Thomas Skinner (1):
> > fix #4411: openid: add logic for openid groups support
> >
> > src/PVE/API2/OpenId.pm | 83 ++++++++++++++++++++++++++++++++++++++++
> > src/PVE/AccessControl.pm | 2 +-
> > src/PVE/Auth/OpenId.pm | 25 ++++++++++++
> > src/PVE/Auth/Plugin.pm | 1 +
> > 4 files changed, 110 insertions(+), 1 deletion(-)
> >
> >
> > docs:
> >
> > Thomas Skinner (1):
> > fix #4411: openid: add docs for openid groups support
> >
> > pveum.adoc | 37 +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> >
> >
> > manager:
> >
> > Thomas Skinner (1):
> > fix #4411: openid: add ui config for openid groups support
> >
> > www/manager6/dc/AuthEditOpenId.js | 34 ++++++++++++++++++++++++++++---
> >
> >
> > proxmox-openid:
> >
> > Thomas Skinner (1):
> > fix #4411: openid: add library code for generic id token claim support
> >
> > proxmox-openid/src/lib.rs | 55 +++++++++++++++++++++++++++++++++------
> > --
> > 2.39.5
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
> Thank you for the v4!
>
> I gave it a spin with Authentik again as OIDC provider.
> It behaved as expected, including the log message for invalid group
> names:
> ```
> Mar 25 17:24:26 pve80-ceph18-staging-1 pvedaemon[31077]: openid group
> 'test!2345' contains invalid characters
> ```
>
> One small issue with the docs patch, but other than that:
>
> Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
>
Submitted a v5 with the doc fix. Thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-27 1:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 2:37 Thomas Skinner
2025-03-24 2:37 ` [pve-devel] [PATCH docs v4 1/1] fix #4411: openid: add docs for openid groups support Thomas Skinner
2025-03-25 16:37 ` Mira Limbeck
2025-03-24 2:37 ` [pve-devel] [PATCH proxmox-openid v4 1/1] fix #4411: openid: add library code for generic id token claim support Thomas Skinner
2025-03-24 2:37 ` [pve-devel] [PATCH access-control v4 1/1] fix #4411: openid: add logic for openid groups support Thomas Skinner
2025-03-24 2:37 ` [pve-devel] [PATCH manager v4 1/1] fix #4411: openid: add ui config " Thomas Skinner
2025-03-25 16:35 ` [pve-devel] [PATCH SERIES access-control/docs/manager/proxmox-openid v4] fix #4411: add support for openid groups Mira Limbeck
2025-03-27 1:51 ` Thomas Skinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALn9RMeuzL2Px7H+Fjg1Qq=0T8Amk6F8h1o4zNdibFTOXyuS-A@mail.gmail.com' \
--to=thomas@atskinner.net \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal