public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Skinner <thomas@atskinner.net>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC pve-manager 0/1] Node maintenance set state for the UI
Date: Mon, 18 Aug 2025 11:12:42 -0500	[thread overview]
Message-ID: <CALn9RMdxHi_0RmN+CfK4fayLW9yrd=UUzdy-NKAm-m-GckX=gA@mail.gmail.com> (raw)
In-Reply-To: <mailman.184.1748932551.395.pve-devel@lists.proxmox.com>

> From: Tiago Sousa <joao.sousa@eurotux.com>
> To: pve-devel@lists.proxmox.com
> Cc:
> Bcc:
> Date: Mon,  2 Jun 2025 17:10:51 +0100
> Subject: [RFC pve-manager 0/1] Node maintenance set state for the UI
> This patch addresses feature request
> https://bugzilla.proxmox.com/show_bug.cgi?id=6144  to add support for
> setting a node's maintenance state directly from the UI and API.
>
> This implementation uses Sys.PowerMgmt permission for now, but I'm
> unsure if this is the most appropriate. Could there be a better
> permission level?
>
> The API endpoint location at /nodes/{node_name}/node-maintenance-set
> seems logical, but feedback on placement would be appreciated.
>
> Tiago Sousa (1):
>   add ha node maintenance mode to the UI and API
>
>  PVE/API2/Nodes.pm            | 45 ++++++++++++++++++++++++++++++++++++
>  www/manager6/Utils.js        |  1 +
>  www/manager6/node/CmdMenu.js | 36 +++++++++++++++++++++++++++--
>  3 files changed, 80 insertions(+), 2 deletions(-)
>
> --
> 2.39.5

Tiago, I have an implementation of this function in my local PVE 8
branches that we're using. Would it be helpful for me to send over my
patches to you? We have the API implemented under the pve-ha-manager
repo and the HA UI like Thomas Lamprecht was mentioning in the patch
threads. I was going to send my patches in, but I hadn't had a chance
yet until recently. I don't want to step on your toes if you're
working it either.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


       reply	other threads:[~2025-08-18 16:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.184.1748932551.395.pve-devel@lists.proxmox.com>
2025-08-18 16:12 ` Thomas Skinner [this message]
2025-08-18 20:37   ` Joao Sousa via pve-devel
2025-06-02 16:10 Tiago Sousa via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALn9RMdxHi_0RmN+CfK4fayLW9yrd=UUzdy-NKAm-m-GckX=gA@mail.gmail.com' \
    --to=thomas@atskinner.net \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal