public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Bowder <daniel@bowdernet.com>
To: pve-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager
Date: Thu, 9 Jun 2022 08:43:21 -0700	[thread overview]
Message-ID: <CA+=Vt23XTvHFVt9GRkRXODbniEJj56dD9VQ1NLhcn8NhcPJ3=Q@mail.gmail.com> (raw)

> Is a string the best way of entering the CPUs in the GUI? Maybe a
> dropdown where you can (un)select the cores?

It would be a nice gui element to have a list of CPU cores with the ability
to select individual ones. Such a feature would require the Options.js to
know how many CPU cores the system had to dynamically generate the
list I do not know how one would get that information to Options.js, but it
certainly seems feasible. The cpuset list must be created eventually so
that the cpuset can be used by taskset, so the underlying data structure
remains this string.

I do not yet have the required knowledge to add a dynamically generated
list of CPU cores in the Options.js file. I do have the required knowledge
to add this string formatted list.

I would argue that having the feature in the GUI as a string is acceptable
as a version 1 implementation. The string format does not lock us into
anything and the gui can be upgraded to a fancy list in the future with no
hindrances. The cpuset format in $vmid.conf is the way that this variable
should be stored, so on the backend, there's nothing to change.


             reply	other threads:[~2022-06-09 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 15:43 Daniel Bowder [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-06-08 11:54 [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning Daniel Bowder
2022-06-08 11:54 ` [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager Daniel Bowder
2022-06-08 14:39   ` Matthias Heiserer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Vt23XTvHFVt9GRkRXODbniEJj56dD9VQ1NLhcn8NhcPJ3=Q@mail.gmail.com' \
    --to=daniel@bowdernet.com \
    --cc=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal