Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning

[Daniel Bowder <daniel@bowdernet.com>]

> Yes, exactly! Make sure to also add a version in the commit message(e.g:
> "[pve-devel] [PATCH v2 pve-manager 4/5] fix #3593"), and describe which
> changes were made since the last version. You can take a look at other
> mails so see how it is done:
> https://lists.proxmox.com/pipermail/pve-devel/, and in the Developer
> Documentation in the section "Preparing Patches".

> I suggest you wait a bit before sending in a v2, I'll first test your
patch.

Sounds good. I will:
1. read up on Preparing Patches
2. correct my formatting settings
3. wait to hear your feedback for incorporation with v2

On Wed, Jun 8, 2022 at 6:32 AM Matthias Heiserer <m.heiserer@proxmox.com>
wrote:

> On 08.06.2022 15:21, Daniel Bowder wrote:
> >> Thank you for your patches!
> > You are welcome.
> >
> >> Regarding the formatting: Please make sure to follow our Perl and
> >> Javascript style guides [0][1] and the Developer Documentation [2]. All
> >> your patches use a nonconformant indentation :/
> > I do apologize for that. I read [0] and [2] in their entirety multiple
> > times. I was very careful to make sure I didn't have any lines that were
> >
> > 100 chars and I tried to follow the formatting guidelines. I'll need to
> fix
> > my editor to match the indentation specifications.
> No worries, the formatting is a bit unusual.
>
> >
> >> Also, the repository (e.g. qemu-server) should be part of the prefix,
> >> next to "PATCH", this makes it easier to parse where they belong.
> > The instructions on [2] under #Preparing_Patches are a little ambiguous
> > when it comes to changes to multiple repos that are all related.
> > Specifically when making changes to multiple repos for one related task.
> >
> > # cd pve-manager; git format-patch -s -o /tmp/patchq -1
> > # cd ../pve-guest-common; git format-patch -s -o /tmp/patchq -1
> > # cd ../pve-docs; git format-patch -s -o /tmp/patchq -1
> > # git send-email --compose --to=pve-devel@lists.proxmox.com
> /tmp/patchq/*
> >
> > I didn't follow these completely blindly, but, I also wasn't 100% certain
> > what to change for a multi-repo review vs  a single repo review. I'll
> make
> > sure to include [ PATCH xxxx a/b ] for each xxxx repo patch in the
> future.
> >
> >> In case you haven't done so yet, we require a CLA (explained in [2])
> >> from you in order to use your code.
> > I sent in the CLA just before submitting the patches.
>
> Great!>
> > I'm somewhat of a noob when it comes to mailing lists as opposed to
> working
> > off of branches in a repo. Do I resubmit my patches in the same way that
> I
> > did previously after I've resolved the indentation issues?
> >
> Yes, exactly! Make sure to also add a version in the commit message(e.g:
> "[pve-devel] [PATCH v2 pve-manager 4/5] fix #3593"), and describe which
> changes were made since the last version. You can take a look at other
> mails so see how it is done:
> https://lists.proxmox.com/pipermail/pve-devel/, and in the Developer
> Documentation in the section "Preparing Patches".
>
> I suggest you wait a bit before sending in a v2, I'll first test your
> patch.
>
>
> > On Wed, Jun 8, 2022 at 6:00 AM Matthias Heiserer <m.heiserer@proxmox.com
> >
> > wrote:
> >
> >> On 08.06.2022 13:54, Daniel Bowder wrote:
> >>> These five patches add the ability to pin a QEMU VMs processes to a
> >> defined set of CPU cores. The changes required spanned multiple repos
> and
> >> have all been included in these five patches. The patches add "cpuset"
> as
> >> an option in the qm configuration file and enable the editing of this
> >> parameter via the gui.
> >>>
> >>
> >> Thank you for your patches!
> >>
> >> Regarding the formatting: Please make sure to follow our Perl and
> >> Javascript style guides [0][1] and the Developer Documentation [2]. All
> >> your patches use a nonconformant indentation :/
> >> Also, the repository (e.g. qemu-server) should be part of the prefix,
> >> next to "PATCH", this makes it easier to parse where they belong.
> >>
> >> In case you haven't done so yet, we require a CLA (explained in [2])
> >> from you in order to use your code.
> >>
> >>
> >> [0] https://pve.proxmox.com/wiki/Perl_Style_Guide
> >> [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide
> >> [2] https://pve.proxmox.com/wiki/Developer_Documentation
> >>
> >>
> >
>
>
>