From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES qemu-server/storage] improve RBD resize
Date: Tue, 6 Jun 2023 19:45:01 +0200 [thread overview]
Message-ID: <9ffb8d1e-ae84-0964-0bd4-1b7667e15272@proxmox.com> (raw)
In-Reply-To: <20230428123209.124097-1-f.ebner@proxmox.com>
Am 28/04/2023 um 14:32 schrieb Fiona Ebner:
> Make the way the block_resize QMP command is used consistent with
> what other block device backed storages like ZFS and LVM(thin) do.
>
> Avoid the --allow-shrink flag that should never be required in our
> code and avoid passing floating point numbers to the rbd resize
> command.
>
>
> qemu-server:
>
> Fiona Ebner (1):
> block resize: avoid passing zero size to QMP command
>
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> pve-storage:
>
> Fiona Ebner (2):
> rbd: don't specify allow-shrink flag
> rbd: volume resize: avoid passing floating point value to rbd
>
> PVE/Storage/RBDPlugin.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
applied series, wrapping the ceil in an int(), just to be sure - thanks!
prev parent reply other threads:[~2023-06-06 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 12:32 [pve-devel] " Fiona Ebner
2023-04-28 12:32 ` [pve-devel] [PATCH qemu-server 1/1] block resize: avoid passing zero size to QMP command Fiona Ebner
2023-04-28 12:32 ` [pve-devel] [PATCH storage 1/2] rbd: don't specify allow-shrink flag Fiona Ebner
2023-04-28 12:32 ` [pve-devel] [PATCH storage 2/2] rbd: volume resize: avoid passing floating point value to rbd Fiona Ebner
2023-06-06 17:37 ` Thomas Lamprecht
2023-06-07 8:51 ` Fiona Ebner
2023-06-06 17:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ffb8d1e-ae84-0964-0bd4-1b7667e15272@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox