From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 2/2] reuse existing cloud-init disks
Date: Fri, 30 Sep 2022 10:21:41 +0200 [thread overview]
Message-ID: <9ff40c74-480b-2bb3-02d3-f6549988ef26@proxmox.com> (raw)
In-Reply-To: <20220929133612.388969-2-m.limbeck@proxmox.com>
Am 29.09.22 um 15:36 schrieb Mira Limbeck:
> When a disk exists but is not referenced in the config, it will be
> reused instead of dying during the attempt to allocate the disk.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> This patch is not required to fix the rollback code, but might be nice
> to have in addition since there will still be some users with cloud-init
> disks left on the storage.
>
Nothing wrong with the patch AFAICT, just not fully convinced that it's
worth the added complexity. The $create_disks sub is already a bit
unwieldy unfortunately. So I'm fine with and without this patch :)
next prev parent reply other threads:[~2022-09-30 8:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 13:36 [pve-devel] [PATCH qemu-server 1/2] fix #4201: delete cloud-init disk on rollback Mira Limbeck
2022-09-29 13:36 ` [pve-devel] [PATCH qemu-server 2/2] reuse existing cloud-init disks Mira Limbeck
2022-09-30 8:21 ` Fiona Ebner [this message]
2022-09-30 8:21 ` [pve-devel] [PATCH qemu-server 1/2] fix #4201: delete cloud-init disk on rollback Fiona Ebner
2022-09-30 9:19 ` Mira Limbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ff40c74-480b-2bb3-02d3-f6549988ef26@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox