From: Fiona Ebner <f.ebner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container v5 24/32] add LXC::Namespaces module
Date: Tue, 25 Mar 2025 14:06:56 +0100 [thread overview]
Message-ID: <9fdeed3f-1058-4031-a2a5-d8097e21decf@proxmox.com> (raw)
In-Reply-To: <hsfomw3dds6nt3aaachflz2tqo2vwaygq4ahkhmq2aqsjvvw3w@xgnv3oqzky3r>
Am 24.03.25 um 13:38 schrieb Wolfgang Bumiller:
> On Fri, Mar 21, 2025 at 02:48:44PM +0100, Fiona Ebner wrote:
>> diff --git a/src/PVE/LXC/Namespaces.pm b/src/PVE/LXC/Namespaces.pm
>> new file mode 100644
>> index 0000000..e4b1e5f
>> --- /dev/null
>> +++ b/src/PVE/LXC/Namespaces.pm
>> @@ -0,0 +1,60 @@
>> +package PVE::LXC::Namespaces;
>> +
>> +use strict;
>> +use warnings;
>> +
>> +use Fcntl qw(O_WRONLY);
>> +use Socket;
>> +
>> +use PVE::Tools;
>> +
>> +use constant {CLONE_NEWNS => 0x00020000,
>> + CLONE_NEWUSER => 0x10000000};
>
> nit: ^ those can be imported from `PVE::Tools`.
Will do so in v6.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-25 13:07 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 13:48 [pve-devel] [PATCH-SERIES qemu/common/storage/qemu-server/container/manager v5 00/32] backup provider API Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu v5 01/32] PVE backup: add target ID in backup state Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu v5 02/32] PVE backup: get device info: allow caller to specify filter for which devices use fleecing Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu v5 03/32] PVE backup: implement backup access setup and teardown API for external providers Fiona Ebner
2025-03-24 13:02 ` Wolfgang Bumiller
2025-03-25 10:51 ` Fiona Ebner
2025-03-25 11:11 ` Fiona Ebner
2025-03-25 11:22 ` Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu v5 04/32] PVE backup: implement bitmap support for external backup access Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu v5 05/32] PVE backup: backup-access api: indicate situation where a bitmap was recreated Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH common v5 06/32] syscall: expose fallocate syscall Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH storage v5 07/32] add storage_has_feature() helper function Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH storage v5 08/32] common: add deallocate " Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH storage v5 09/32] plugin: introduce new_backup_provider() method Fiona Ebner
2025-03-24 15:43 ` Wolfgang Bumiller
2025-03-25 12:50 ` Fiona Ebner
2025-03-27 11:03 ` Wolfgang Bumiller
2025-03-27 13:58 ` Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH storage v5 10/32] config api/plugins: let plugins define sensitive properties themselves Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH storage v5 11/32] plugin api: bump api version and age Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH storage v5 12/32] extract backup config: delegate to backup provider for storages that support it Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [POC storage v5 13/32] add backup provider example Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [POC storage v5 14/32] Borg example plugin Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 15/32] backup: keep track of block-node size for fleecing Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 16/32] backup: fleecing: use exact size when allocating non-raw fleecing images Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 17/32] backup: allow adding fleecing images also for EFI and TPM Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 18/32] backup: implement backup for external providers Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 19/32] backup: implement restore " Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 20/32] backup restore: external: hardening check for untrusted source image Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 21/32] backup: future-proof checks for QEMU feature support Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 22/32] backup: support 'missing-recreated' bitmap action Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH qemu-server v5 23/32] backup: bitmap action to human: lie about TPM state Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 24/32] add LXC::Namespaces module Fiona Ebner
2025-03-24 12:38 ` Wolfgang Bumiller
2025-03-25 13:06 ` Fiona Ebner [this message]
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 25/32] backup: implement backup for external providers Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 26/32] backup: implement restore " Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 27/32] external restore: don't use 'one-file-system' tar flag when restoring from a directory Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 28/32] create: factor out compression option helper Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 29/32] restore tar archive: check potentially untrusted archive Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH container v5 30/32] api: add early check against restoring privileged container from external source Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH manager v5 31/32] ui: backup: also check for backup subtype to classify archive Fiona Ebner
2025-03-21 13:48 ` [pve-devel] [PATCH manager v5 32/32] backup: implement backup for external providers Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdeed3f-1058-4031-a2a5-d8097e21decf@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal