From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully
Date: Mon, 25 Sep 2023 13:36:06 +0200 [thread overview]
Message-ID: <9fd2a62c-7976-346d-b0f5-45e4424cdf42@proxmox.com> (raw)
In-Reply-To: <e215d978-0e79-41e0-a37a-142fb2324495@proxmox.com>
Am 25.09.23 um 13:17 schrieb Dominik Csapak:
>
> sorry for the late answer
>
> the patch LGTM, but i would even go a step further and do a
> ----
> value ??= [];
> ----
>
> before the isArray check (that way we'd also handle undefined/null values)
> (can ofc be done as a follow-up/later)
>
>
> an alternative would be to filter out all empty values e.g. like this:
>
> ---
> value.split(',').filter(v => v !== '')
> ---
>
> this would then also handle values like: '100,,200'
> idk if that's even possible to get here
>
Thank you for the review! I'll send a v3 with the suggested changes.
prev parent reply other threads:[~2023-09-25 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 8:02 Fiona Ebner
2023-07-07 8:02 ` [pve-devel] [PATCH v2 manager 2/2] ui: vm selector: don't add invalid not found items Fiona Ebner
2023-09-25 11:18 ` Dominik Csapak
2023-08-30 9:15 ` [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully Fiona Ebner
2023-09-25 10:59 ` Fiona Ebner
2023-09-25 11:17 ` Dominik Csapak
2023-09-25 11:36 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fd2a62c-7976-346d-b0f5-45e4424cdf42@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox