From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 2/2] ui: backup job details: show notification-mode instead of legacy keys
Date: Fri, 11 Jul 2025 09:42:38 +0200 [thread overview]
Message-ID: <9fc1d8da-c35c-42fa-955d-514765cdf314@proxmox.com> (raw)
In-Reply-To: <f0b814ce-8a09-4900-a50b-4ed7c752d963@proxmox.com>
On 7/9/25 10:18, Lukas Wagner wrote:
>
> Good point. For v3, I slightly shortened the strings to
>
> "Always send email"
> "Send email on failure"
>
> Also, instead of rendering the recipient addresses in the same field by appending them to the string,
> I created a second display field "Recipients", which is only visible if the legacy mode
> will be used. If it is visible, but no mail address has been added
>
> "No recipients configured"
>
> is now shown.
>
> What do you think about this approach?
>
Just had a look at how you implemented this in v3 and I think that works
a lot better. Thanks for adapting it!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-11 7:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 11:28 [pve-devel] [PATCH pve-guest-common v2 1/1] backup job: remove 'notification-policy' and 'notification-target' options Lukas Wagner
2025-06-24 11:28 ` [pve-devel] [PATCH manager v2 1/2] ui: remove handling of obsolete notification-policy/target settings Lukas Wagner
2025-06-24 11:28 ` [pve-devel] [PATCH manager v2 2/2] ui: backup job details: show notification-mode instead of legacy keys Lukas Wagner
2025-07-08 18:07 ` Michael Köppl
2025-07-09 7:12 ` Lukas Wagner
2025-07-11 7:41 ` Michael Köppl
2025-07-08 18:17 ` Michael Köppl
2025-07-09 8:18 ` Lukas Wagner
2025-07-11 7:42 ` Michael Köppl [this message]
2025-07-08 18:20 ` [pve-devel] [PATCH pve-guest-common v2 1/1] backup job: remove 'notification-policy' and 'notification-target' options Michael Köppl
2025-07-09 8:20 ` [pve-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc1d8da-c35c-42fa-955d-514765cdf314@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox