From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs
Date: Fri, 22 Sep 2023 16:02:02 +0200 [thread overview]
Message-ID: <9f72e6a3-c40c-4b1a-a18e-2b4ce5cd47f8@proxmox.com> (raw)
In-Reply-To: <20230921130917.2000926-1-p.hufnagl@proxmox.com>
LGTM now, and tested fine (this time with ISOs *and* CT templates ;) )
two tiny nits:
the commit message of the first message could mention that the parameter is necessary
to differentiate between different needs for different content types, but
imho not super important now (could be fixed up e.g.)
the last hunk in the second patch seems leftover, but it only removes an empty line,
so it should do any harm.
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
next prev parent reply other threads:[~2023-09-22 14:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 13:09 Philipp Hufnagl
2023-09-21 13:09 ` [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression Philipp Hufnagl
2023-09-26 10:56 ` Thomas Lamprecht
2023-09-26 12:25 ` Philipp Hufnagl
2023-09-26 14:23 ` Thomas Lamprecht
2023-09-26 14:54 ` Philipp Hufnagl
2023-09-26 14:57 ` Thomas Lamprecht
2023-09-27 8:03 ` Philipp Hufnagl
2023-09-27 8:33 ` Thomas Lamprecht
2023-09-27 8:57 ` Philipp Hufnagl
2023-09-27 17:19 ` Thomas Lamprecht
2023-09-21 13:09 ` [pve-devel] [PATCH manager v8 2/2] fix #4849: ui: " Philipp Hufnagl
2023-09-26 10:59 ` Thomas Lamprecht
2023-09-26 12:27 ` Philipp Hufnagl
2023-09-22 14:02 ` Dominik Csapak [this message]
2023-09-26 7:39 ` [pve-devel] applied-series: [PATCH manager v9 0/2] fix #4849: allow download of compressed ISOs Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f72e6a3-c40c-4b1a-a18e-2b4ce5cd47f8@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox