From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH novnc] don't show error messages for users without VM.Audit privileges
Date: Mon, 10 Oct 2022 10:45:47 +0200 [thread overview]
Message-ID: <9efc06ed-91ed-1f32-4d07-86b16a48052a@proxmox.com> (raw)
In-Reply-To: <20221007084458.1242670-1-d.csapak@proxmox.com>
Am 07/10/2022 um 10:44 schrieb Dominik Csapak:
> we now query the guest status before starting, but that requires VM.Audit
> privileges, which are not necessary since only VM.Console is actually
> required to connect to the console.
>
> In that case, skip the error message and continue connecting
>
> reported in the forum:
> https://forum.proxmox.com/threads/vm-console-require-vm-audit.116176/
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> ...ow-start-button-on-not-running-vm-ct.patch | 26 ++++++++++++++-----
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
>
applied, but reworked commit message for more context (or maybe better said,
reword it such that it's a bit clearer why/what/how) and to avoid sounding a
bit like that this is a front end solution for a issue where we allowed to
query the guest status if only VM.Console was present, thanks!
prev parent reply other threads:[~2022-10-10 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 8:44 [pve-devel] " Dominik Csapak
2022-10-10 8:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9efc06ed-91ed-1f32-4d07-86b16a48052a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox