From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab
Date: Mon, 7 Apr 2025 19:46:50 +0200 [thread overview]
Message-ID: <9ee6e2b0-7918-43a0-827c-314121b3fa42@proxmox.com> (raw)
In-Reply-To: <20250108143812.241488-2-g.goller@proxmox.com>
Am 08.01.25 um 15:38 schrieb Gabriel Goller:
> adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the
> returned data with the existing configuration. This will update the
> IPv4 and IPv6 address, as well as the interface name (in case the
> container changed it).
>
> Originally-by: Leo Nunner <l.nunner@proxmox.com>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> www/manager6/lxc/Network.js | 85 ++++++++++++++++++++++++++-----------
> 1 file changed, 60 insertions(+), 25 deletions(-)
>
the network view's grid gets broken here for any container that is not
turned on, and thus cannot have an address configured.
Using Proxmox.Async and early return/continue to reduce some
indentation level might be good to.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:38 [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and " Gabriel Goller
2025-01-08 14:38 ` [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in " Gabriel Goller
2025-04-07 17:46 ` Thomas Lamprecht [this message]
2025-04-08 10:06 ` Gabriel Goller
2025-04-08 10:18 ` Thomas Lamprecht
2025-04-08 11:27 ` Gabriel Goller
2025-04-08 11:30 ` Thomas Lamprecht
2025-04-08 12:15 ` Gabriel Goller
2025-04-08 12:20 ` Thomas Lamprecht
2025-01-08 14:38 ` [pve-devel] [PATCH manager v4 2/3] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2025-01-08 14:38 ` [pve-devel] [PATCH container v4 3/3] api: return all addresses of an interface Gabriel Goller
2025-04-07 17:55 ` [pve-devel] applied: " Thomas Lamprecht
2025-01-08 15:58 ` [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and network tab Daniel Herzig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee6e2b0-7918-43a0-827c-314121b3fa42@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal