From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 manager 0/4] BackupView as TreePanel
Date: Wed, 6 Apr 2022 13:26:01 +0200 [thread overview]
Message-ID: <9ec05845-0654-c211-8f84-f05ad8e01ab6@proxmox.com> (raw)
In-Reply-To: <20220404130211.4138797-1-m.heiserer@proxmox.com>
Am 04.04.22 um 15:02 schrieb Matthias Heiserer:
> Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
>
> Matthias Heiserer (4):
> ui: Utils: Helpers for backup type and icon
> ui: storage: Rewrite backup content view as TreePanel.
> ui: delete BackupView and replace it with the new Tree BackupView
> ui: content view: remove dead code
>
> www/manager6/Makefile | 1 -
> www/manager6/Utils.js | 20 +
> www/manager6/grid/BackupView.js | 388 -------------
> www/manager6/lxc/Config.js | 2 +-
> www/manager6/qemu/Config.js | 2 +-
> www/manager6/storage/BackupView.js | 817 +++++++++++++++++++++-------
> www/manager6/storage/ContentView.js | 43 +-
> 7 files changed, 657 insertions(+), 616 deletions(-)
> delete mode 100644 www/manager6/grid/BackupView.js
>
Great! I've just got one complaint left (and a few nits, see my answer
to 2/4). Repeating the complaint here:
I feel like we should always filter by backup type in the guest view
like is done currently. Otherwise, there is the possibility to try and
restore e.g. an LXC backup over an existing VM. That probably isn't a
common use case, and it just leads to an error.
But even if we don't go for that, consider the series
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2022-04-06 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 13:02 Matthias Heiserer
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 1/4] ui: Utils: Helpers for backup type and icon Matthias Heiserer
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 2/4] ui: storage: Rewrite backup content view as TreePanel Matthias Heiserer
2022-04-06 11:25 ` Fabian Ebner
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 3/4] ui: delete BackupView and replace it with the new Tree BackupView Matthias Heiserer
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 4/4] ui: content view: remove dead code Matthias Heiserer
2022-04-06 11:26 ` Fabian Ebner [this message]
2022-04-06 15:40 ` [pve-devel] [PATCH v4 manager 0/4] BackupView as TreePanel Thomas Lamprecht
2022-04-07 6:31 ` Fabian Ebner
2022-04-07 6:57 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec05845-0654-c211-8f84-f05ad8e01ab6@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox