From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Jing Luo <jing@jing.rocks>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock
Date: Mon, 24 Mar 2025 14:11:06 +0100 [thread overview]
Message-ID: <9e41496d-468e-4206-90c3-0048a0ec8d56@proxmox.com> (raw)
In-Reply-To: <39e9a7cd767a4de295ab573fa71c7722@jing.rocks>
Am 24.03.25 um 14:04 schrieb Jing Luo:
> I just found that this is technically a systemd thing: at boot time,
> systemd creates the symlinks /var/run -> /run and /var/lock ->
> /run/lock, this
> is written in /usr/lib/tmpfiles.d/var.conf and
> /usr/lib/tmpfiles.d/legacy.conf,
> which has been true at least since Debian switched to systemd in 2015.
>
> So these two have always been symlinks (unless the machine has not been
> restarted
> in the past 10+ years).
>
> [1] https://wiki.debian.org/ReleaseGoals/RunDirectory
>
Thanks for checking, then it indeed seems fine to just do those two
specific path moves without any extra coordination or backward compat
code required.
So for moving file paths from /var/run/ to /run/ and /var/lock/ to
/run/lock, i.e. where the actual location of the file does not change
at all due the respective pairs pointing to the exact same directory,
this series is:
Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Anything where the underlying directory changes is still NAK'd if it
does not come with some backward compat handling code, FWICT this is
really just the single vzdump.lock patch though.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-24 13:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250322152004.1646886-1-jing@jing.rocks>
2025-03-22 15:17 ` Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH] rust-proxmox-network-api: change /var/lock to /run/lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pmg-api] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH] rust-proxmox-backup: change " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-cluster] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-common] " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-container] tree-wide: change /var/run to /run Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-firewall] tree-wide: change /var/run to /run and /var/lock to /run/lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-guest-common] tree-wide: change " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-storage] " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH qemu-server] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
[not found] ` <20250322152004.1646886-2-jing@jing.rocks>
2025-03-24 8:02 ` [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock Thomas Lamprecht
2025-03-24 11:41 ` Jing Luo via pve-devel
[not found] ` <d8306d3000f15b2dc4dad5f0be32db4f@jing.rocks>
2025-03-24 11:56 ` Thomas Lamprecht
2025-03-24 13:04 ` Jing Luo via pve-devel
[not found] ` <39e9a7cd767a4de295ab573fa71c7722@jing.rocks>
2025-03-24 13:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e41496d-468e-4206-90c3-0048a0ec8d56@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=jing@jing.rocks \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal