Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline: convert drive to blockdev syntax

[Fiona Ebner <f.ebner@proxmox.com>]

Am 06.05.25 um 16:20 schrieb DERUMIER, Alexandre:
> 
> Am 22.04.25 um 13:51 schrieb Alexandre Derumier via pve-devel:
>>
>> fixme:
>>  - rbd blockdev don't allow extra options (keyring file for example),
>>    do we need to patch qemu ? or write client option in a file ?
> 
> I think following upstream and using a dedicated config file is
> better/more future-proof here.
> 
> 
>>> I'd prefer to create the file in /run/qemu-
>>> server/${storeid}.ceph.conf
>>> rather than in /etc/pve/priv. It only contains the path to the key
>>> file
>>> and that path itself is not secret.
> 
> yes, I was thinking about same.
> 
> They are interesting rbd client option that we could add later
> https://bugzilla.proxmox.com/show_bug.cgi?id=6290
> crush_location=host:myhost|datacenter:mydc
> read_from_replica=localize
> 
> 
> They are a case about rbd_cache_policy option forced to writeback
> for efi disk (I have made a comment in later patch).
> I think it's not yet needed anymore as it look to be fixed upstream,
> but if we need it, This is a specific option for a specific disk, and
> not the whole storeid.
> 
> so, in this case, I don't known if we need a conf like
> /run/qemuserver/vm-{vmid}-{drive}-.ceph.conf?

If the options are not fixed for a given storage/disk, then yes, we'll
need to have a generated config per VM or per drive even. But we can
easily adapt the path we use for the generated config later when the
need arises. Just need to make sure we pass along the path we generated
to the QEMU commandline and not hard-code it :)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel