From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit 2/2] node/APTRepositories: rework top status and error grid
Date: Fri, 2 Jul 2021 15:43:41 +0200 [thread overview]
Message-ID: <9e1be71a-ac9a-ebf4-baa1-959253286503@proxmox.com> (raw)
In-Reply-To: <20210702104859.3515832-2-d.csapak@proxmox.com>
On 02.07.21 12:48, Dominik Csapak wrote:
> instead of having a title bar and a seperate error grid,
> add an always visible panel that displays the status (ok, warning, errors)
> which also contains the error grid (if necessary, ala ceph summary)
>
> this makes the panel more consistent to use and it is immediatly
> visible if something is wrong
>
> this also adds a test for the 'test' repositories, as well as a test
> for not correctly configured suites
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> we should probably only emit a warning for suites for Proxmox and Debian
> origin, since other vendors may use different suites for their packages
> (e.g. google ships all chrome debs in the 'stable' suite)
>
> src/node/APTRepositories.js | 147 ++++++++++++++++++++++++------------
> 1 file changed, 98 insertions(+), 49 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-07-02 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 10:48 [pve-devel] [PATCH widget-toolkit 1/2] Utils: add get_health_icon from PVE Dominik Csapak
2021-07-02 10:48 ` [pve-devel] [PATCH widget-toolkit 2/2] node/APTRepositories: rework top status and error grid Dominik Csapak
2021-07-02 13:43 ` Thomas Lamprecht [this message]
2021-07-02 13:43 ` [pve-devel] applied: [PATCH widget-toolkit 1/2] Utils: add get_health_icon from PVE Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e1be71a-ac9a-ebf4-baa1-959253286503@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox