public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH docs v2] acme: add note about validation delay
@ 2024-06-18 14:15 Folke Gleumes
  2024-06-18 14:37 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Folke Gleumes @ 2024-06-18 14:15 UTC (permalink / raw)
  To: pve-devel

The effect and unit of the validation delay was unclear from our
documentation, and the link to the acme.sh documentation didn't explain
it either

Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
---

since v1:
* slight rewording suggested by Alex

 certificate-management.adoc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/certificate-management.adoc b/certificate-management.adoc
index 639c15a..fb22398 100644
--- a/certificate-management.adoc
+++ b/certificate-management.adoc
@@ -177,7 +177,9 @@ interface (`Datacenter -> ACME`).
 [thumbnail="screenshot/gui-datacenter-acme-add-dns-plugin.png"]
 
 Choose `DNS` as challenge type. Then you can select your API provider, enter
-the credential data to access your account over their API.
+the credential data to access your account over their API. The validation delay determines the
+time in seconds between setting the DNS record and prompting the ACME provider to validate it,
+as providers often need some time to propagate the record in their infrastructure.
 
 TIP: See the acme.sh
 https://github.com/acmesh-official/acme.sh/wiki/dnsapi#how-to-use-dns-api[How to use DNS API]
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH docs v2] acme: add note about validation delay
  2024-06-18 14:15 [pve-devel] [PATCH docs v2] acme: add note about validation delay Folke Gleumes
@ 2024-06-18 14:37 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-06-18 14:37 UTC (permalink / raw)
  To: Proxmox VE development discussion, Folke Gleumes

Am 18/06/2024 um 16:15 schrieb Folke Gleumes:
> The effect and unit of the validation delay was unclear from our
> documentation, and the link to the acme.sh documentation didn't explain
> it either
> 
> Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
> ---
> 
> since v1:
> * slight rewording suggested by Alex
> 
>  certificate-management.adoc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

I reflowed the text-width to 80 cc though, while 100 cc is fine in general,
this file was quite strictly honoring 80 cc, so the addition rather stuck
out, but just for the record, it's only a very tiny stylistic nit after all.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-18 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-18 14:15 [pve-devel] [PATCH docs v2] acme: add note about validation delay Folke Gleumes
2024-06-18 14:37 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal