public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Folke Gleumes <f.gleumes@proxmox.com>
Subject: [pve-devel] applied: [PATCH docs v2] acme: add note about validation delay
Date: Tue, 18 Jun 2024 16:37:51 +0200	[thread overview]
Message-ID: <9dc83ae3-a5f4-493b-9111-f9cf933a2c6f@proxmox.com> (raw)
In-Reply-To: <20240618141527.1465807-1-f.gleumes@proxmox.com>

Am 18/06/2024 um 16:15 schrieb Folke Gleumes:
> The effect and unit of the validation delay was unclear from our
> documentation, and the link to the acme.sh documentation didn't explain
> it either
> 
> Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
> ---
> 
> since v1:
> * slight rewording suggested by Alex
> 
>  certificate-management.adoc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

I reflowed the text-width to 80 cc though, while 100 cc is fine in general,
this file was quite strictly honoring 80 cc, so the addition rather stuck
out, but just for the record, it's only a very tiny stylistic nit after all.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-06-18 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 14:15 [pve-devel] " Folke Gleumes
2024-06-18 14:37 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dc83ae3-a5f4-493b-9111-f9cf933a2c6f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gleumes@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal