From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES v4 manager] add protected and notes-template parameters for vzdump
Date: Thu, 28 Apr 2022 18:30:48 +0200 [thread overview]
Message-ID: <9d833853-ab25-32e4-1fc1-22c9b2efd773@proxmox.com> (raw)
In-Reply-To: <20220427154116.115071-1-f.ebner@proxmox.com>
On 27.04.22 17:41, Fabian Ebner wrote:
> Introduce 'protected' to automatically mark a backup as protected
> upon completion, and 'notes-template' to generate notes from a
> template string with certain variables.
>
> Add both to the UI for manual backups and add 'notes-template' to the
> UI for backup jobs.
>
> Changes from v3:
> * dropped already applied patches
> * also expand \\ and \n and have notes-template be a single line
> so that it can be written to job config
> * die on unexpected variable or escape character
>
>
> Missing adapt description in common and add something to docs (will do
> so tomorrow).
>
>
> Fabian Ebner (6):
> partially close #438: vzdump: support setting notes-template
> ui: util: add helpers for (un)escaping notes-template
> ui: backup: allow setting protected and notes-template for manual
> backup
> close #438: ui: backup job: allow setting a notes-template for a job
> ui: dc/backup: (un)escape notes-template
> vzdump: generate notes: die upon unexpected escape character or
> variable
>
> Thomas Lamprecht (1):
> ui: dc/backup: move note template to own tab and adapt
>
> PVE/VZDump.pm | 38 ++++++++++++++++++++++++++
> www/manager6/Utils.js | 16 +++++++++++
> www/manager6/dc/Backup.js | 51 ++++++++++++++++++++++++++++++++++-
> www/manager6/window/Backup.js | 34 ++++++++++++++++++++++-
> 4 files changed, 137 insertions(+), 2 deletions(-)
>
applied, thanks!
prev parent reply other threads:[~2022-04-28 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 15:41 [pve-devel] " Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 1/7] partially close #438: vzdump: support setting notes-template Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 2/7] ui: util: add helpers for (un)escaping notes-template Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 3/7] ui: backup: allow setting protected and notes-template for manual backup Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 4/7] close #438: ui: backup job: allow setting a notes-template for a job Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 5/7] ui: dc/backup: move note template to own tab and adapt Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 6/7] ui: dc/backup: (un)escape notes-template Fabian Ebner
2022-04-27 15:41 ` [pve-devel] [PATCH v4 manager 7/7] vzdump: generate notes: die upon unexpected escape character or variable Fabian Ebner
2022-04-28 16:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d833853-ab25-32e4-1fc1-22c9b2efd773@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox