Re: [pve-devel] [PATCH container 1/2] fix #2938: increase limit of max cores from 128 to 512

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 9/14/20 12:32 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PVE/LXC/Config.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 4cd669c..223b10e 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -401,14 +401,14 @@ my $confdesc = {
>  	type => 'integer',
>  	description => "The number of cores assigned to the container. A container can use all available cores by default.",
>  	minimum => 1,
> -	maximum => 128,
> +	maximum => 512,
>      },
>      cpulimit => {
>  	optional => 1,
>  	type => 'number',
>  	description => "Limit of CPU usage.\n\nNOTE: If the computer has 2 CPUs, it has a total of '2' CPU time. Value '0' indicates no CPU limit.",
>  	minimum => 0,
> -	maximum => 128,
> +	maximum => 512,
>  	default => 0,
>      },
>      cpuunits => {
> 

why 512? please give state some actual reason for choosing such a number,
especially if it differs from our current kernel config value of 8192...

https://git.proxmox.com/?p=mirror_ubuntu-focal-kernel.git;a=blob;f=arch/x86/Kconfig;h=8ef85139553f5a4ad5187375af898266355c4177;hb=b311b46c7d1ab21bf0a11a6fa5bad76f98fb77af#l1014