From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH lxc 2/2] include common.conf in openwrt configuration
Date: Mon, 8 Nov 2021 15:14:12 +0100 [thread overview]
Message-ID: <9d591837-6bff-ce61-e5dd-e1a01561f547@proxmox.com> (raw)
In-Reply-To: <20211108134400.1884660-3-o.bektas@proxmox.com>
On 08.11.21 14:44, Oguz Bektas wrote:
> necessary for the container to start, otherwise we get stuck in creating
> /dev directory.
why though and what from common settings actually helps would be good to
clarify in such patches..
FWIW, the conf seems very outdated, e.g., lxc tty dirs do not matter much
nowadays IIRC, I'd rather revise/update them a bit more in-depth *after*
the next releases.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> config/openwrt.common.conf.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config/openwrt.common.conf.in b/config/openwrt.common.conf.in
> index 73db6f6..aa2e332 100644
> --- a/config/openwrt.common.conf.in
> +++ b/config/openwrt.common.conf.in
> @@ -1,3 +1,6 @@
> +# This derives from the global common config.
> +lxc.include = @LXCTEMPLATECONFIG@/common.conf
> +
> # Default console settings
> lxc.tty.dir = lxc
> lxc.tty.max = 4
>
next prev parent reply other threads:[~2021-11-08 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 13:43 [pve-devel] [PATCH 0/2] openwrt container support Oguz Bektas
2021-11-08 13:43 ` [pve-devel] [PATCH container 1/2] fix #2044: add openwrt support Oguz Bektas
2021-11-08 13:46 ` Oguz Bektas
2021-11-08 15:11 ` Thomas Lamprecht
2021-11-09 10:57 ` Oguz Bektas
2021-11-08 13:44 ` [pve-devel] [PATCH lxc 2/2] include common.conf in openwrt configuration Oguz Bektas
2021-11-08 14:14 ` Thomas Lamprecht [this message]
2021-11-08 22:17 ` [pve-devel] [PATCH 0/2] openwrt container support Juri Grabowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d591837-6bff-ce61-e5dd-e1a01561f547@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox