From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: fix search for 'Guests without Backup' window
Date: Fri, 20 Jan 2023 09:56:29 +0100 [thread overview]
Message-ID: <9d35ef4e-e860-9385-5400-37422d6df6d9@proxmox.com> (raw)
In-Reply-To: <20230120084710.94577-1-l.wagner@proxmox.com>
Am 20/01/2023 um 09:47 schrieb Lukas Wagner:
> In JS, a `for (const a in <...>)` loop iterates over indices, not
> over values. To iterate over values, `for (const a of <..>)` has
> to be used. Furthermore, filtering by ID did not work properly, since
> the property is called `vmid`, not `id`.
seems it was not adapted when copying over from the job detail window
code.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/dc/BackupJobDetail.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-01-20 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 8:47 [pve-devel] " Lukas Wagner
2023-01-20 8:56 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d35ef4e-e860-9385-5400-37422d6df6d9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox