public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v1 1/3] fix #4888: qmrestore: add diskformat option
Date: Tue, 4 Feb 2025 17:21:38 +0100	[thread overview]
Message-ID: <9d0e70fb-3bc1-4d98-bfc3-8e9f7e42ee5a@proxmox.com> (raw)
In-Reply-To: <20250204161340.351956-1-m.frank@proxmox.com>

Am 04.02.25 um 17:13 schrieb Markus Frank:
> Add an option to choose a file format (qcow2, raw, vmdk) when restoring
> a vm backup to file based storage. This options allows all disks to be
> recreated with the specified file format if supported by the target
> storage.
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> Choosing the file format and storage for each disk would require much
> more change and would be more in line with Feature Request #4275.

It's not that much more change. And if we add this now and then the
implementation for the other feature, we'll have duplicate/conflicting
options, which is also not nice. We can deprecate this option then of
course and later drop, but why not just go for the more complete
solution directly? Or at least a solution that can be built upon for
adding that feature later?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-02-04 16:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 16:13 Markus Frank
2025-02-04 16:13 ` [pve-devel] [PATCH manager v1 2/3] ui: form: add hideFormatWhenStorageEmpty option to DiskStorageSelector Markus Frank
2025-02-04 16:13 ` [pve-devel] [PATCH manager v1 3/3] ui: window: add diskformat option to the restore window Markus Frank
2025-02-04 16:21 ` Fiona Ebner [this message]
2025-02-04 16:39   ` [pve-devel] [PATCH qemu-server v1 1/3] fix #4888: qmrestore: add diskformat option Fiona Ebner
2025-02-04 16:44     ` Markus Frank
2025-02-04 16:53       ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d0e70fb-3bc1-4d98-bfc3-8e9f7e42ee5a@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal