From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Duerr <h.duerr@proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-network v2 1/8] ipam: netbox: factor out common api methods and unify error handling
Date: Mon, 7 Apr 2025 17:45:30 +0200 [thread overview]
Message-ID: <9d0d26ad-28e8-475f-aa65-61e8fc27572b@proxmox.com> (raw)
In-Reply-To: <e51bc9fe-4286-45ed-930d-eef79bef05fc@proxmox.com>
Am 07.04.25 um 17:38 schrieb Thomas Lamprecht:
> Am 07.04.25 um 17:32 schrieb Hannes Duerr:
>> Tested this series against netbox version 4.2.2 and didn't run into any
>> issues.
>> Created and deleted a simple zone with two vnets and respective subnet.
>> The prefixes were created and deleted correctly
>> Assigned and removed VMs to the vnets and the ip addresses were created
>> and removed correctly.
>
> If you reply with a Tested-by the `b4 am -tl` I recently quite often use
> to apply series can automatically pick that trailer up, so having proper
> trailers in test and/or review replies would be really appreciated.
Saw your message with the T-b just now, thanks!
But other thing @Stefan Hanreich: if you send a cover-letter then others,
and b4, could easier differentiate for an R-b or T-b applying to just a
single patch or the whole series. So cover letters with a short gist
of the series and series-wide changelogs would be appreciated too, and
not only for better compatibility with b4 that's just a nice side benefit.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 8:50 Stefan Hanreich
2025-03-10 8:50 ` [pve-devel] [PATCH pve-network v2 2/8] ipam: netbox: implement deleting subnets Stefan Hanreich
2025-03-10 8:50 ` [pve-devel] [PATCH pve-network v2 3/8] ipam: netbox: simplify helpers Stefan Hanreich
2025-03-10 8:50 ` [pve-devel] [PATCH pve-network v2 4/8] ipam: netbox: no conditional assignments for descriptions Stefan Hanreich
2025-03-10 8:51 ` [pve-devel] [PATCH pve-network v2 5/8] ipam: netbox: add error handling to get_ips_from_mac Stefan Hanreich
2025-03-10 8:51 ` [pve-devel] [PATCH pve-network v2 6/8] partial fix #5496: ipam: netbox: properly return allocated ip Stefan Hanreich
2025-03-10 8:51 ` [pve-devel] [PATCH pve-network v2 7/8] partial fix #5496: ipam: netbox: create / delete ip ranges for dhcp Stefan Hanreich
2025-03-10 8:51 ` [pve-devel] [PATCH pve-network v2 8/8] partial fix #5496: subnet: ipam: add update_subnet hook Stefan Hanreich
2025-04-07 15:32 ` [pve-devel] [PATCH pve-network v2 1/8] ipam: netbox: factor out common api methods and unify error handling Hannes Duerr
2025-04-07 15:37 ` Hannes Duerr
2025-04-07 15:38 ` Thomas Lamprecht
2025-04-07 15:45 ` Thomas Lamprecht [this message]
2025-04-07 15:49 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0d26ad-28e8-475f-aa65-61e8fc27572b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal