public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>,
	Constantin Herold <proxmox8914@herold.me>
Subject: Re: [pve-devel] [PATCH v3 qemu-server 1/1] fix #2429: allow to specify cloud-init vendor snippet via cicustom
Date: Thu, 4 Nov 2021 13:15:49 +0100	[thread overview]
Message-ID: <9ccbdbfc-29be-5cc8-ca40-63c586bd92bc@proxmox.com> (raw)
In-Reply-To: <2c93696a-e7c5-d7dc-8430-0520b858e27e@proxmox.com>

On 04.11.21 12:28, Mira Limbeck wrote:
> Looks good.
> 
> Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>

With that: applied, thanks to both.

I added Mira's suggested comment regarding the size limitation as a followup:
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=115cb432bcd90e00a487d1ed5ad28c4158dd0e47




      reply	other threads:[~2021-11-04 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 14:49 Constantin Herold
2021-11-04 11:28 ` Mira Limbeck
2021-11-04 12:15   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ccbdbfc-29be-5cc8-ca40-63c586bd92bc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=proxmox8914@herold.me \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal