public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH container 1/1] status: add some missing descriptions for status return properties
Date: Thu, 24 Oct 2024 17:12:48 +0200	[thread overview]
Message-ID: <9ca78cd4-862f-4927-addd-9f0080d9b926@proxmox.com> (raw)
In-Reply-To: <85f03434-d2e9-49bd-a39f-406c3eb6dd59@proxmox.com>

Am 24/10/2024 um 17:05 schrieb Dominik Csapak:
> On 10/24/24 14:20, Thomas Lamprecht wrote:
>> Am 21/10/2024 um 11:15 schrieb Dominik Csapak:
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>> ---
>>>   src/PVE/LXC.pm | 43 ++++++++++++++++++++++++++++++++++++++++++-
>>>   1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>
>>
>> applied, thanks! FYI: I had to fix a duplicate key (see below) and made a few
>> small adjustments to the wording (not just your additions) as a separate follow-up.
>>
>>> +    netin => {
>>> +	description => "The amount of traffic that was sent to the guest since the process start,"
>>> +	    ." in bytes.",
>>> +	type => 'integer',
>>> +	optional => 1,
>>> +	renderer => 'bytes',
>>> +    },
>>> +    netin => {
>>
>> changed this to netout and folded that into your commit.
> 
> uff, thanks for that. seems i was too fast with the copy&paste...
> 

yeah, no worries, I just thought fixing that up on applying was overall
quicker compared to requesting a v2 (that I then might overlook/forget for
a few days).

> i wonder if our check target could catch something like that, but
> probably not i guess

Would be nice if perl could warn about those things, FWIW perlcritic does
not catches this either and perl just takes the last value.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-10-24 15:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21  9:15 [pve-devel] [PATCH qemu-server/container/manager] add some missing return schema descriptions Dominik Csapak
2024-10-21  9:15 ` [pve-devel] [PATCH qemu-server 1/1] status: add some missing description for status return properties Dominik Csapak
2024-10-24 13:53   ` [pve-devel] applied: " Thomas Lamprecht
2024-10-21  9:15 ` [pve-devel] [PATCH container 1/1] status: add some missing descriptions " Dominik Csapak
2024-10-24 12:20   ` [pve-devel] applied: " Thomas Lamprecht
2024-10-24 15:05     ` Dominik Csapak
2024-10-24 15:12       ` Thomas Lamprecht [this message]
2024-10-21  9:15 ` [pve-devel] [PATCH manager 1/2] api: subscription: add return schema for 'GET' api Dominik Csapak
2024-10-24 15:02   ` [pve-devel] applied: " Thomas Lamprecht
2024-10-21  9:15 ` [pve-devel] [PATCH manager 2/2] api: cluster/resources: add missing return properties Dominik Csapak
2024-10-24 15:02   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ca78cd4-862f-4927-addd-9f0080d9b926@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal