From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 manager] api: apt: repos: fix interfacing with perlmod
Date: Thu, 15 Jul 2021 09:48:05 +0200 [thread overview]
Message-ID: <9c994ff9-e316-99ae-c77a-df75313f663b@proxmox.com> (raw)
In-Reply-To: <20210715065126.11237-1-f.ebner@proxmox.com>
Am 15.07.21 um 08:51 schrieb Fabian Ebner:
> Using
> pvesh create /nodes/pve701/apt/repositories --path
> "/etc/apt/sources.list" --index 0 --enabled 1
> reliably leads to
> error: invalid type: string "0", expected usize
>
> Coerce to int to avoid this. I was not able to trigger the issue with
> the "enabled" option here (in PMG I was), but be on the safe side and
> coerce there too.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Added the v2 in the subject this time, sorry.
>
> Changes from v1:
> * avoid creating an implicit default by checking definedness first
>
> PVE/API2/APT.pm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index bd60db33..310d875f 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API2/APT.pm
> @@ -750,13 +750,16 @@ __PACKAGE__->register_method({
> code => sub {
> my ($param) = @_;
>
> + my $enabled = $param->{enabled};
> + $enabled = int($enabled) if defined($enabled);
> +
> my $options = {
> - enabled => $param->{enabled},
> + enabled => $enabled,
> };
>
> PVE::RS::APT::Repositories::change_repository(
> $param->{path},
> - $param->{index},
> + int($param->{index}),
> $options,
> $param->{digest}
> );
>
This still doesn't work reliably for some reason, but it's very strange:
Seems like when enabled is not passed as a parameter, it's sometimes
interpreted as Some(false) even if it's undef in Perl. I was not able to
trigger it with pvesh, only when sending the requests via Firefox dev tools.
prev parent reply other threads:[~2021-07-15 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 6:51 Fabian Ebner
2021-07-15 7:48 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c994ff9-e316-99ae-c77a-df75313f663b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox