public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9
Date: Thu, 25 Jul 2024 14:38:52 +0200	[thread overview]
Message-ID: <9c8e05ac-1f81-46dd-b1e3-53dc08f2a33f@proxmox.com> (raw)
In-Reply-To: <818f3b6c-b802-464d-bbe6-136124a5abae@proxmox.com>

For the record, we talked about this in person for a bit with the following
outcome:

- there was a bit of a misunderstanding w.r.t. my heavy exaggeration for the
  point's sake, I really did not mean that as accusation at all, but that's
  now talked out

- it's a good point that the package that was included in the first 7.0 ISO
  release was already new enough API version wise, and we also checked the
  package archives, and there we also got only new enough libpve-storage-perl
  package versions, so we can keep the change as is.
  We also agreed that it would be great to mention such analysis in the commit
  message the next time, and I know Fiona is very thorough with that stuff, and
  that this time it was just not mentioned due to the difference in how upgrade
  requirements and recommendations got interpreted by her and me, so I mention
  this mostly for other readers, as this applies to all of us.

- we might want to document this expectation w.r.t API backward compat more
  definitively in a more approachable way, but should ensure that its clarified
  that this is for developers, not users, to avoid users thinking its always
  fine to upgrade from an outdated point release to a newer major release.

tl;dr: got sorted out and change can be kept as is


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-07-25 12:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  9:04 Fiona Ebner
2024-07-02 17:14 ` Max Carrara
2024-07-03 12:26 ` [pve-devel] applied: " Fiona Ebner
2024-07-04  9:52 ` [pve-devel] " Thomas Lamprecht
2024-07-04 10:28   ` Fiona Ebner
2024-07-04 11:51     ` Thomas Lamprecht
2024-07-04 12:11       ` Fiona Ebner
2024-07-04 17:45         ` Thomas Lamprecht
2024-07-05  8:22           ` Fiona Ebner
2024-07-25 12:38             ` Thomas Lamprecht [this message]
2024-07-05  7:45         ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c8e05ac-1f81-46dd-b1e3-53dc08f2a33f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal