Re: [pve-devel] [PATCH pve-manager] qemu: bump max cores to 256 by socket

[Dominik Csapak <d.csapak@proxmox.com>]

On 1/12/24 21:08, Alexandre Derumier wrote:
> New epyc cpu already support 168 threads
> 
> qemu 8.1 support 1024 cores with q35
> ---
>   www/manager6/qemu/ProcessorEdit.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
> index b845ff66..b3538727 100644
> --- a/www/manager6/qemu/ProcessorEdit.js
> +++ b/www/manager6/qemu/ProcessorEdit.js
> @@ -125,7 +125,7 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
>   	    xtype: 'proxmoxintegerfield',
>   	    name: 'cores',
>   	    minValue: 1,
> -	    maxValue: 128,
> +	    maxValue: 256,
>   	    value: '1',
>   	    fieldLabel: gettext('Cores'),
>   	    allowBlank: false,


mhmm.. in the backend we don't actually have a limit, maybe it's time to remove the limit in the ui
altogether? it does not help anyway:

for numbers that are not too big (too many for qemu, too many for the host)
it's not the right limit (qemu) or we don't know at that point in the gui (host cores)

but in case next year there is e.g. a 512 core machine, the limit is too low again...


so i'd be either for
* removing the limit at all
* limit to the qemu limits (but maybe also in the backend?)
* use the number of cores of the current host as limit in the gui (should be possible, but an 
additional api call)

what do you think?