From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-installer] answer: perform basic input validation for keyboard
Date: Wed, 24 Apr 2024 11:34:25 +0200 [thread overview]
Message-ID: <9c0caecf-6a24-4523-962a-81213a855faf@proxmox.com> (raw)
In-Reply-To: <20240424084850.204194-1-c.ebner@proxmox.com>
Am 24/04/2024 um 10:48 schrieb Christian Ebner:
> Currently it is possible to validate and create an iso with an
> invalid keyboad layout, only failing later during installation.
>
> Add a basic check for correct keyboard layout by defining an enum
> with allowed variants.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> proxmox-auto-installer/src/answer.rs | 39 +++++++++++++++++++++++++++-
> proxmox-auto-installer/src/utils.rs | 8 ++++--
> 2 files changed, 44 insertions(+), 3 deletions(-)
>
>
applied, with a follow-up to use serde_plain::derive_display_from_serialize
to derive the Display impl, thanks!
btw. if we probably want to use the same perl code that generates the valid
list for the installer environment to output that at build time in such a
way that we can source it from rust on build.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-24 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 8:48 [pve-devel] " Christian Ebner
2024-04-24 9:20 ` Stoiko Ivanov
2024-04-24 9:26 ` Christian Ebner
2024-04-24 9:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c0caecf-6a24-4523-962a-81213a855faf@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox