From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH stable-7 manager 2/2] pve7to8: avoid confusing warning about required setting 'storage' for vzdump
Date: Wed, 21 Jun 2023 18:16:37 +0200 [thread overview]
Message-ID: <9c07a334-7f81-1c05-818e-2ca535d755f3@proxmox.com> (raw)
In-Reply-To: <20230621150201.100421-2-f.ebner@proxmox.com>
Am 21/06/2023 um 17:02 schrieb Fiona Ebner:
> It's required in the schema for notes-template and protected, but when
> parsing vzdump.conf, it shouldn't matter whether the storage parameter
> is set or not.
>
> The warning is ugly and users might interpret it as something that
> needs to be acted upon for the upgrade:
> parse error in '/etc/vzdump.conf' - 'storage': missing property - 'notes-template' requires this property\nmissing property - 'protected' requires this property
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Intended for both master and stable-7.
>
> PVE/CLI/pve7to8.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-06-21 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:02 [pve-devel] [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention Fiona Ebner
2023-06-21 15:02 ` [pve-devel] [PATCH stable-7 manager 2/2] pve7to8: avoid confusing warning about required setting 'storage' for vzdump Fiona Ebner
2023-06-21 16:16 ` Thomas Lamprecht [this message]
2023-06-21 16:16 ` [pve-devel] applied: [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c07a334-7f81-1c05-818e-2ca535d755f3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox