* [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.
@ 2021-09-03 6:36 Alexandre Derumier
2021-10-05 5:21 ` Thomas Lamprecht
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Derumier @ 2021-09-03 6:36 UTC (permalink / raw)
To: pve-devel
This option don't have any impact on device itself.
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
PVE/QemuServer.pm | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index cc73af8..09701e0 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4743,6 +4743,8 @@ sub vmconfig_hotplug_pending {
} elsif ($opt eq 'cpulimit') {
my $cpulimit = $conf->{pending}->{$opt} == 0 ? -1 : int($conf->{pending}->{$opt} * 100000);
$cgroup->change_cpu_quota($cpulimit, 100000);
+ } elsif ($opt eq 'agent') {
+ vmconfig_update_agent($conf, $opt, $value);
} else {
die "skip\n"; # skip non-hot-pluggable options
}
@@ -4902,6 +4904,23 @@ sub vmconfig_update_net {
}
}
+sub vmconfig_update_agent {
+ my ($conf, $opt, $value) = @_;
+
+ if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
+
+ my $agent = parse_guest_agent({$opt => $value});
+
+ # skip non hotpluggable value
+ if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
+ safe_string_ne($agent->{type}, $old_agent->{type})) {
+ die "skip\n";
+ }
+ }
+ die "skip\n";
+
+}
+
sub vmconfig_update_disk {
my ($storecfg, $conf, $hotplug, $vmid, $opt, $value, $arch, $machine_type) = @_;
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.
2021-09-03 6:36 [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option Alexandre Derumier
@ 2021-10-05 5:21 ` Thomas Lamprecht
2021-10-05 9:48 ` DERUMIER, Alexandre
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Lamprecht @ 2021-10-05 5:21 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexandre Derumier
On 03.09.21 08:36, Alexandre Derumier wrote:
> This option don't have any impact on device itself.
>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> PVE/QemuServer.pm | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index cc73af8..09701e0 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4743,6 +4743,8 @@ sub vmconfig_hotplug_pending {
> } elsif ($opt eq 'cpulimit') {
> my $cpulimit = $conf->{pending}->{$opt} == 0 ? -1 : int($conf->{pending}->{$opt} * 100000);
> $cgroup->change_cpu_quota($cpulimit, 100000);
> + } elsif ($opt eq 'agent') {
> + vmconfig_update_agent($conf, $opt, $value);
> } else {
> die "skip\n"; # skip non-hot-pluggable options
> }
> @@ -4902,6 +4904,23 @@ sub vmconfig_update_net {
> }
> }
>
> +sub vmconfig_update_agent {
> + my ($conf, $opt, $value) = @_;
> +
> + if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
> +
> + my $agent = parse_guest_agent({$opt => $value});
> +
> + # skip non hotpluggable value
> + if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
> + safe_string_ne($agent->{type}, $old_agent->{type})) {
> + die "skip\n";
> + }
> + }
> + die "skip\n";
but this method always skips no matter what?
> +
> +}
> +
> sub vmconfig_update_disk {
> my ($storecfg, $conf, $hotplug, $vmid, $opt, $value, $arch, $machine_type) = @_;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.
2021-10-05 5:21 ` Thomas Lamprecht
@ 2021-10-05 9:48 ` DERUMIER, Alexandre
0 siblings, 0 replies; 3+ messages in thread
From: DERUMIER, Alexandre @ 2021-10-05 9:48 UTC (permalink / raw)
To: pve-devel, t.lamprecht, aderumier
+sub vmconfig_update_agent {
+ my ($conf, $opt, $value) = @_;
+
+ if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
+
+ my $agent = parse_guest_agent({$opt => $value});
+
+ # skip non hotpluggable value
+ if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
+ safe_string_ne($agent->{type}, $old_agent->{type})) {
+ die "skip\n";
+ }
+ }
+ die "skip\n";
but this method always skips no matter what?
oh, sorry, it should be in an else (agent is disabled)
I just sent a fixed v2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-05 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 6:36 [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option Alexandre Derumier
2021-10-05 5:21 ` Thomas Lamprecht
2021-10-05 9:48 ` DERUMIER, Alexandre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox