From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH common] fix #4547: set MTU on dynamically created vlan bridges
Date: Fri, 24 Feb 2023 17:03:17 +0100 [thread overview]
Message-ID: <9baf58a3-7367-ec80-00b9-a41e114ad816@proxmox.com> (raw)
In-Reply-To: <20230224110621.765001-1-d.csapak@proxmox.com>
On 24/02/2023 12:06, Dominik Csapak wrote:
> Otherwise the created vlan bridge has the default MTU, which is
> unexpected when the original bridge has some other MTU configured.
>
> We already do this for the firewall bridges, so we should do so too for
> the vlan bridges.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> technically this is a breaking change i think, since someone might
> depend on the fact that the vlan bridges always have the default mtu,
> but there is no way to configure that besides from manually modifying
> the /etc/network/interfaces file, so not completely sure
> if we want to do that now, or with the next major release
meh, if we adopt that view on what a breaking change is we wouldn't
be allowed to fix any bug ;-)
>
> src/PVE/Network.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2023-02-24 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 11:06 [pve-devel] " Dominik Csapak
2023-02-24 16:03 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9baf58a3-7367-ec80-00b9-a41e114ad816@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox