From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property
Date: Wed, 14 Jun 2023 15:57:34 +0200 [thread overview]
Message-ID: <9b363fbe-20c2-2bde-d9c4-9dc0186041a9@proxmox.com> (raw)
In-Reply-To: <4331ed65-7014-cbb3-9ae6-245a3bb293cc@proxmox.com>
Am 14/06/2023 um 14:51 schrieb Fiona Ebner:
> Am 13.06.23 um 15:42 schrieb Alexander Zeidler:
>> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
>> ---
>> src/PVE/VZDump/Common.pm | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
>> index a6fe483..28ab0d3 100644
>> --- a/src/PVE/VZDump/Common.pm
>> +++ b/src/PVE/VZDump/Common.pm
>> @@ -282,6 +282,12 @@ my $confdesc = {
>> requires => 'storage',
>> optional => 1,
>> },
>> + "pbs-entries-max" => {
>> + type => 'integer',
>> + description => "Override max number of entries to hold in memory (only applicable for PBS).",
>> + optional => 1,
>> + minimum => 1,
>> + },
>> };
>
> Now I'm wondering if this would make sense as part of the 'performance'
> setting? Depending on how you interpret it, it could fit or not. Any
> other opinions?
+1, rather re-use existing infra for this and the performance settings are
a good enough fit, FWICT
prev parent reply other threads:[~2023-06-14 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 13:42 [pve-devel] [PATCH manager/container/guest-common 0/4] fix #3069: add pbs-entries-max to vzdump.conf Alexander Zeidler
2023-06-13 13:42 ` [pve-devel] [PATCH manager 1/4] api: backup: refactor backup permission check Alexander Zeidler
2023-06-14 9:49 ` Fiona Ebner
2023-06-13 13:42 ` [pve-devel] [PATCH manager 2/4] add 'pbs-entries-max' to permission check & config Alexander Zeidler
2023-06-13 13:42 ` [pve-devel] [PATCH container 3/4] add 'pbs-entries-max' parameter Alexander Zeidler
2023-06-14 9:49 ` Fiona Ebner
2023-06-13 13:42 ` [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property Alexander Zeidler
2023-06-14 9:49 ` Fiona Ebner
2023-06-14 12:51 ` Fiona Ebner
2023-06-14 13:57 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b363fbe-20c2-2bde-d9c4-9dc0186041a9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox