public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/2] ui: CephInstallWizard: make first mon node static
Date: Wed, 7 Sep 2022 15:26:39 +0200	[thread overview]
Message-ID: <9b1864f2-2b9b-f17c-2771-4917e8c38b14@proxmox.com> (raw)
In-Reply-To: <20220810151020.573769-1-a.lauterer@proxmox.com>

Am 10/08/2022 um 17:10 schrieb Aaron Lauterer:
> Removes the possibility to select the node on which to create the first
> monitor in the configuration / initialization step and always sets it to
> the current node.
> 
> This prevents that a user might select another node on which the Ceph
> packages have not yet been installed. If a user did that, they would get
> an error, but the Ceph config file would have been written. If the user
> then does not select a valid node to create the first mon, but aborts
> the wizard, they are greeted with a rados_connect error because the
> config file exists, but it does not contain any mon infos that are
> needed to connect to the Ceph cluster.
> 
> Creating a mon manually will remedy such a situation, but especially for
> new users, this behavior is not ideal and confusing.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  www/manager6/ceph/CephInstallWizard.js | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
>

applied, thanks!




      parent reply	other threads:[~2022-09-07 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 15:10 [pve-devel] " Aaron Lauterer
2022-08-10 15:10 ` [pve-devel] [PATCH manager 2/2] ui: CephInstall: fix a/an typo Aaron Lauterer
2022-09-07 13:28   ` [pve-devel] applied: " Thomas Lamprecht
2022-09-07 13:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b1864f2-2b9b-f17c-2771-4917e8c38b14@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal