* [pve-devel] [PATCH] fix compressor loop-order
@ 2021-07-14 16:52 Stoiko Ivanov
2021-07-15 9:31 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2021-07-14 16:52 UTC (permalink / raw)
To: pve-devel
commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in
the logic - once a file is downloaded the 'last;' statement exited the
inner loop iterating over the compoentens instead of the outer one
iterating over the compressors.
since both do not inherently depend on each other simply swap them.
noticed while trying to build a pmg-template in a clean environment
with full repository configuration (before the tests worked due to
leftover files in the infodir)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
Sorry for the inconvenience!
DAB.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/DAB.pm b/DAB.pm
index b81321e..9282789 100644
--- a/DAB.pm
+++ b/DAB.pm
@@ -648,8 +648,8 @@ sub initialize {
warn "Release info ignored\n";
};
- foreach my $compressor (@$COMPRESSORS) {
- foreach my $comp (@{$ss->{comp}}) {
+ foreach my $comp (@{$ss->{comp}}) {
+ foreach my $compressor (@$COMPRESSORS) {
$path = "dists/$ss->{suite}/$comp/binary-$arch/Packages.$compressor->{ext}";
$target = "$infodir/" . __url_to_filename ("$ss->{source}/$path");
my $pkgsrc = "$src/$path";
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH] fix compressor loop-order
2021-07-14 16:52 [pve-devel] [PATCH] fix compressor loop-order Stoiko Ivanov
@ 2021-07-15 9:31 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-15 9:31 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
On 14.07.21 18:52, Stoiko Ivanov wrote:
> commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in
> the logic - once a file is downloaded the 'last;' statement exited the
> inner loop iterating over the compoentens instead of the outer one
> iterating over the compressors.
>
> since both do not inherently depend on each other simply swap them.
>
> noticed while trying to build a pmg-template in a clean environment
> with full repository configuration (before the tests worked due to
> leftover files in the infodir)
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Sorry for the inconvenience!
>
> DAB.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-15 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 16:52 [pve-devel] [PATCH] fix compressor loop-order Stoiko Ivanov
2021-07-15 9:31 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox