public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 4/4] ui: backup job: simplify translatable string
Date: Wed, 12 Jun 2024 14:39:52 +0200	[thread overview]
Message-ID: <9ae908a4-bbb7-484e-bdcb-352dddd58975@proxmox.com> (raw)
In-Reply-To: <20240423082714.123525-4-m.sandoval@proxmox.com>

Am 23.04.24 um 10:27 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  www/manager6/panel/BackupAdvancedOptions.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
> index b9e5304e..4b31f403 100644
> --- a/www/manager6/panel/BackupAdvancedOptions.js
> +++ b/www/manager6/panel/BackupAdvancedOptions.js
> @@ -231,7 +231,7 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
>  	    xtype: 'component',
>  	    padding: '5 1',
>  	    html: `<span class="pmx-hint">${gettext('Note')}</span>: ${
> -	        gettext("The node-specific 'vzdump.conf' or, if this is not set, the default from the config schema is used to determine fallback values.")}`,
> +	        gettext("The node-specific 'vzdump.conf'. If not set, the defaults from the config schema are used to determine fallback values.")}`,
>  	},
>      ],
>  });

"The node-specific 'vzdump.conf'." is not a proper sentence.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-06-12 12:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23  8:27 [pve-devel] [PATCH manager 1/4] ui: homogenize uses of Zstd and SCSI Maximiliano Sandoval
2024-04-23  8:27 ` [pve-devel] [PATCH manager 2/4] ui: guest import: fix typo on 'attached' Maximiliano Sandoval
2024-04-23  8:27 ` [pve-devel] [PATCH manager 3/4] ui: backup job: inline translatable string Maximiliano Sandoval
2024-04-23  8:27 ` [pve-devel] [PATCH manager 4/4] ui: backup job: simplify " Maximiliano Sandoval
2024-06-12 12:39   ` Fiona Ebner [this message]
2024-06-12 12:39 ` [pve-devel] [PATCH manager 1/4] ui: homogenize uses of Zstd and SCSI Fiona Ebner
2024-07-10 13:03 ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ae908a4-bbb7-484e-bdcb-352dddd58975@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal