From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column
Date: Thu, 1 Oct 2020 17:22:47 +0200 [thread overview]
Message-ID: <9ad242f9-73be-4f64-99d1-37f4689009a9@proxmox.com> (raw)
In-Reply-To: <8a9a3acc-2552-5fe5-8f6b-11a9e4b28abc@proxmox.com>
On 10/1/20 5:10 PM, Thomas Lamprecht wrote:
> On 01.10.20 14:18, Aaron Lauterer wrote:
>> Allows 2 digits rule numbers to be visible in the column. Made it a bit
>> wider than needed to account for potentially wider font rendering on
>> different platforms.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> www/manager6/grid/FirewallRules.js | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
>> index ec2d1c84..42035129 100644
>> --- a/www/manager6/grid/FirewallRules.js
>> +++ b/www/manager6/grid/FirewallRules.js
>> @@ -629,7 +629,7 @@ Ext.define('PVE.FirewallRules', {
>> // similar to xtype: 'rownumberer',
>> dataIndex: 'pos',
>> resizable: false,
>> - width: 23,
>> + width: 42,
>> sortable: false,
>> align: 'right',
>> hideable: false,
>>
>
> oh, and maybe you can try to switch that whole column definition away from fixed
> widths to relative "flex" only. Just needs to look OK on 720p and quite good on
> 1080p. It's not always possible, but most of the time it works out well and not
> using fixed widths is always nicer, IMO.
>
good point. I'll take a look at it.
next prev parent reply other threads:[~2020-10-01 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 12:18 Aaron Lauterer
2020-10-01 14:44 ` [pve-devel] applied: " Thomas Lamprecht
2020-10-01 15:10 ` [pve-devel] " Thomas Lamprecht
2020-10-01 15:22 ` Aaron Lauterer [this message]
2020-10-02 12:52 ` Aaron Lauterer
2021-02-19 16:45 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ad242f9-73be-4f64-99d1-37f4689009a9@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox