Re: [pve-devel] [PATCH qemu-server v4 05/12] vm_stop_cleanup: add noerr parameter

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 06/06/2024 um 11:22 schrieb Dominik Csapak:
> and set it on all current users

Hmm, it would have helped me if you stated that this patch is keeping
the semantics, but allow callers to request that the method dies instead
of just warning and silencing such an error.

As I was first, when just reading the commit message, a bit confused why
there was no explanation whatsoever even though the behavior changed
drastically - while sure, for review one can reasonably expect devs to also
read the code, it's IMO still much nicer if one already get the basic
gist from just reading the message, ideally just the subject; especially
when writing d/changelog entries.

The subject could maybe be changed to something like:

"vm stop-cleanup: allow callers to decide error behavior"

(in this specific case it might be even fine to use the literal method
name, but no hard feelings either way)

Looks OK to me otherwise.

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

With commit meta stuff addressed consider this:

Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel