From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] workaround for novnc fullscreen behaviour
Date: Tue, 21 Dec 2021 09:06:01 +0100 [thread overview]
Message-ID: <9a6c9c95-c76d-8ec2-8ef9-ec791d8b633d@proxmox.com> (raw)
In-Reply-To: <765472c4-be18-fbfd-8cbd-b8a5996990b3@proxmox.com>
On 12/20/21 20:55, Thomas Lamprecht wrote:
> On 20/12/2021 14:57, Aaron Lauterer wrote:
>> Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
>>
>
> how did you test this if the noVNC patch from Dominik is broken?
Tested the "open in full screen" part of it all, which works with or without the noVNC patches. Meaning, while it opens nicely in full screen and hitting the back button gets me back to where I was before, noVNC still had the fullscreen button in its menu.
next prev parent reply other threads:[~2021-12-21 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:37 Dominik Csapak
2021-12-20 13:57 ` Aaron Lauterer
2021-12-20 19:55 ` Thomas Lamprecht
2021-12-21 8:06 ` Aaron Lauterer [this message]
2021-12-20 19:19 ` [pve-devel] applied: " Thomas Lamprecht
2021-12-20 19:55 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a6c9c95-c76d-8ec2-8ef9-ec791d8b633d@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox