From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 pve-common 3/5] section config: clean up parser logic and semantics
Date: Mon, 11 Nov 2024 16:29:41 +0100 [thread overview]
Message-ID: <9a40eb5a-7db9-44b3-a3c1-c44f3339275f@proxmox.com> (raw)
In-Reply-To: <20241031170720.338794-4-m.carrara@proxmox.com>
Am 31.10.24 um 18:07 schrieb Max Carrara:
> In order to make the parser somewhat more maintainable in the future,
> this commit cleans up its logic and makes its control flow easier to
> follow.
>
> Furthermore, regexes are assigned to variables and some variables are
> renamed in order to make the code more semantically expressive.
>
Leaving this out for now as this would do well with an in-depth review for
which I do not have the time at the moment, but FWIW any other long-term
staff can do that too. Also, it could be nice to check if there are some
more cases for which new tests could be sensible to add before applying
this.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-11 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 17:07 [pve-devel] [PATCH v3 pve-common 0/5] Section Config: Documentation & Code Cleanup Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 1/5] section config: document package and its methods with POD Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 2/5] section config: update code style Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 3/5] section config: clean up parser logic and semantics Max Carrara
2024-11-11 15:29 ` Thomas Lamprecht [this message]
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 4/5] section config: make subroutine `delete_from_config` private Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 5/5] section config: fix spelling of variable Max Carrara
2024-11-11 13:59 ` [pve-devel] partially-applied-series: [PATCH v3 pve-common 0/5] Section Config: Documentation & Code Cleanup Thomas Lamprecht
2024-11-14 8:37 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a40eb5a-7db9-44b3-a3c1-c44f3339275f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox