[pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

[pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

[Christian Ebner]

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 notifications.adoc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/notifications.adoc b/notifications.adoc
index cddb8ca..9be23f8 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -172,11 +172,11 @@ Notification Matchers
 [thumbnail="screenshot/gui-datacenter-notification-matcher.png"]
 
 Notification matchers route notifications to notification targets based
-on their matching rules. These rules can match of certain properties of
-a notification, such as the timestamp (`match-calendar`), the severity of
-the notificaiton (`match-severity`) or metadata fiels (`match-field`).
-If a matcher matches a notification, all targets configured for the matcher
-will receive the notification.
+on their matching rules. These rules can match certain properties of a
+notification, such as the timestamp (`match-calendar`), the severity of
+the notificaiton (`match-severity`) or metadata fields (`match-field`).
+If a notification is matched by a matcher, all targets configured for the
+matcher will receive the notification.
 
 An arbitrary number of matchers can be created, each with with their own
 matching rules and targets to notify.
-- 
2.39.2

Re: [pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

[Lukas Wagner]

On 1/10/24 14:14, Christian Ebner wrote:
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>   notifications.adoc | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/notifications.adoc b/notifications.adoc
> index cddb8ca..9be23f8 100644
> --- a/notifications.adoc
> +++ b/notifications.adoc
> @@ -172,11 +172,11 @@ Notification Matchers
>   [thumbnail="screenshot/gui-datacenter-notification-matcher.png"]
>   
>   Notification matchers route notifications to notification targets based
> -on their matching rules. These rules can match of certain properties of
> -a notification, such as the timestamp (`match-calendar`), the severity of
> -the notificaiton (`match-severity`) or metadata fiels (`match-field`).
> -If a matcher matches a notification, all targets configured for the matcher
> -will receive the notification.
> +on their matching rules. These rules can match certain properties of a
> +notification, such as the timestamp (`match-calendar`), the severity of
> +the notificaiton (`match-severity`) or metadata fields (`match-field`).
                 ^
Spotted another typo here

> +If a notification is matched by a matcher, all targets configured for the
> +matcher will receive the notification.
>   
>   An arbitrary number of matchers can be created, each with with their own
>   matching rules and targets to notify.

I guess I wrote that paragraph in a bit of a hurry :)

Thanks!

-- 
- Lukas

Re: [pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

[Christian Ebner]

> On 10.01.2024 14:37 CET Lukas Wagner <l.wagner@proxmox.com> wrote:
> 
>  
> On 1/10/24 14:14, Christian Ebner wrote:
> > Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> > ---
> >   notifications.adoc | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/notifications.adoc b/notifications.adoc
> > index cddb8ca..9be23f8 100644
> > --- a/notifications.adoc
> > +++ b/notifications.adoc
> > @@ -172,11 +172,11 @@ Notification Matchers
> >   [thumbnail="screenshot/gui-datacenter-notification-matcher.png"]
> >   
> >   Notification matchers route notifications to notification targets based
> > -on their matching rules. These rules can match of certain properties of
> > -a notification, such as the timestamp (`match-calendar`), the severity of
> > -the notificaiton (`match-severity`) or metadata fiels (`match-field`).
> > -If a matcher matches a notification, all targets configured for the matcher
> > -will receive the notification.
> > +on their matching rules. These rules can match certain properties of a
> > +notification, such as the timestamp (`match-calendar`), the severity of
> > +the notificaiton (`match-severity`) or metadata fields (`match-field`).
>                  ^
> Spotted another typo here

Ah, yes, will send a v2. Thanks for noticing!

> 
> > +If a notification is matched by a matcher, all targets configured for the
> > +matcher will receive the notification.
> >   
> >   An arbitrary number of matchers can be created, each with with their own
> >   matching rules and targets to notify.
> 
> I guess I wrote that paragraph in a bit of a hurry :)
> 
> Thanks!

No worries!