From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH novnc] don't automatically connect to not running vms/cts
Date: Thu, 10 Feb 2022 16:15:53 +0100 [thread overview]
Message-ID: <9a1a3668-d4d6-841d-dc08-49f93224d526@proxmox.com> (raw)
In-Reply-To: <20220210093312.1532271-1-d.csapak@proxmox.com>
On 10.02.22 10:33, Dominik Csapak wrote:
> this patch adds a check for the guests status, and show a start button
> instead of connecting to a non-started guest
>
> this should reduce confusion when a guest is not running, and also
> reduce the number of false-positive failed console tasks
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> ...ow-start-button-on-not-running-vm-ct.patch | 197 ++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 198 insertions(+)
> create mode 100644 debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
>
>
good idea, really nice UX addition IMO!
applied, with switching the copied FA play button with the existing power one
(squashed into your patch to avoid having the play button forever in git history
without getting used) - thanks!
prev parent reply other threads:[~2022-02-10 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 9:33 [pve-devel] " Dominik Csapak
2022-02-10 15:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a1a3668-d4d6-841d-dc08-49f93224d526@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox